JamesH1978

Good morning, Can i first ask, if this is a config for a stock lulzbot mini 2? As in, if a person were to purchase this printer, they would get...

Thanks Trent, I can only see a signed off by line on 2 on your commits? I will start to review your code though. Thanks James

Hi, Please read https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and pay particular attention to the signed off by line. Thanks James

Please review https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md particularly the signed off by line Thanks James

Hi @mjruigrok Please can you limit your config to only features than come with the printer, and also remove any save_config, {include] sections, macros. config for resonance testing etc. A...

@mjruigrok thanks for the changes, can you also review https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and make sure you add the regression test additions and https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md paying attention to the signed off line Thanks James

unfortunately we do not accept any submissions without a real name and email address, this is to conform with our DCO https://github.com/Klipper3d/klipper/blob/master/docs/developer-certificate-of-origin and to comply with our open source licences....

Good morning, Thankyou for submitting a config, please can you review https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and pay particular attention to the regression tests, these need to be added to your commit. Can you...

It is point 4 in that document. Please other PR's for an example, such as https://github.com/Klipper3d/klipper/pull/6006 Thanks James

Thankyou for submitting this config, please could you refer to point 4 in https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and other information in that doc and include the regression test, and also https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md paying particular...