JamesH1978
JamesH1978
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James
yes please, split it out, and follow the guidelines for the regression tests as outlined in the doc linked. And you should not update the copyright info in changed code....
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James
@duchengyao Anything to add to this? as this was your original PR? If no objections I will review and likely approve shortly Thank James
We do not include instructions to do testing in configurations. We only include options for a stock machine. If connecions are available on the board for probes with clearly defined...
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James
Thanks for the PR, please refer to point 3 in "Common things a reviewer will look for:" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed-of-by line Thanks James