Klipper3d
Added printer config for SUNLU T3
printer-sunlu-t3-2022: Initial base config for the SUNLU T3 board
Pin outs mined from Marlin source code provided by SUNLU. In the Marlin source, the BTT SKR Mini E3 V2 is referenced. Almost all pin outs were identical to the BTT board. Changes being the use of a GigaDevice chip rather than a STM and running the TMC2209s in standalone mode rather than UART. Testing was done on my own printer for multiple prints before submitting the commit. Only submitted base config required to get the printer running, extra macros and advanced config options removed.
signed-off-by: Zachary Welvaert [[email protected]]
Good morning,
Thankyou for submitting a config, please can you review https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and pay particular attention to the regression tests, these need to be added to your commit.
Can you also confirm this printer ships with a touch style probe device? Repo configs should only describe a stock printer.
Thanks James
pleasecan you review https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and pay particular attention to the regression tests, these need to be added to your commit.
I had read that many times while editing my config for submission and I am pretty sure I have everything from there done correctly. Also do not see anything in there that specifically references "regression tests". Perhaps that is in another document or I may just be not seeing it.
Can you also confirm this printer ships with a touch style probe device? Repo configs should only describe a stock printer.
The printer does come shipped with a bltouch clone, this clone touch probe required "pin_up_touch_mode_reports_triggered: FALSE" to function properly and had reduced accuracy when attempting to use "probe_with_touch_mode" Printer also comes shipped with a filament runout sensor, that pin is also referenced in the config submitted
It is point 4 in that document. Please other PR's for an example, such as https://github.com/Klipper3d/klipper/pull/6006
Thanks James
It is point 4 in that document. Please other PR's for an example, such as #6006
Yeah, I definitely did miss that. That is on me. I will get it added to that list when I have some time this afternoon
Added the config to the printers.test. Unless I missed something else, that should be everything
