JamesH1978

Results 128 comments of JamesH1978

Ah yes, this would be my cock up :) i did indeed put the sock and not the serial. Please can you sign off your PR, and i will review...

fixed by https://github.com/Klipper3d/klipper/pull/6716

@rongith are you saying that octoprint itself does not recognize ~ as a placeholder for /home// If so, i will make some amendments. Thanks, and sorry for missing your reply...

i will do some testing and confirm if the tilde is supported or not, and then make a change accordingly, maybe just state `/home//printer_data` , it shouldnt matter for older...

Thank you for submitting a PR, please refer to point 4 in the guidelines in https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md to add the regression tests, and provide a signed off by line as outlined...

The code you have submitted includes sections that are not available in mainline klipper such as `[bl24c16f]` and we would prefer a [fan] section and not an output pin to...

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James

That one is more likely to be crappy usb bandwdith and trying to run too many usb devices at the same time, even more so if a camera is also...

Thanks for submitting a PR, generally the GD32F303 variants do not need that setting, only the GD32F103 ones. It seems to be a weird quirk that the GD32F303 is a...

Thankyou for submitting a PR, please can you sign off your as mentioned in point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James