Update graph_accelerometer.py

[DrPacemaker]

Usage of undeclared local variable 'header' due to missing indentation

[JamesH1978]

Please review https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md particularly the signed off by line

Thanks James

[KevinOConnor]

@dmbutyugin - any thoughts on this bug report?

-Kevin

[github-actions[bot]]

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

[dmbutyugin]

FWIW, the code is somewhat correct. That is, if a user passes a csv file produced by Klipper, it works, there is no mistake there. I suppose the error could arise if the user passes an empty file as an input. A more proper fix would be

 def parse_log(logname, opts):
     with open(logname) as f:
         for header in f:
-            if not header.startswith('#'):
-                break
+            if header.startswith('#'):
+                continue
-        if not header.startswith('freq,psd_x,psd_y,psd_z,psd_xyz'):
+            if not header.startswith('freq,psd_x,psd_y,psd_z,psd_xyz'):
+                break
             # Raw accelerometer data
             return np.loadtxt(logname, comments='#', delimiter=',')
     # Power spectral density data or shaper calibration data
     opts.error("File %s does not contain raw accelerometer data and therefore "
                "is not supported by graph_accelerometer.py script. Please use "
                "calibrate_shaper.py script to process it instead." % (logname,))

[KevinOConnor]

Okay, thanks. Maybe I'm missing something, but the alternative implementation seems to negate the if not header.startswith('freq,psd_x,psd_y,psd_z,psd_xyz') check.

-Kevin

[dmbutyugin]

@KevinOConnor Yes, you are right. So, I sent another PR #6072 with this fix and a few other small improvements.

[github-actions[bot]]

This ticket is being closed because the underlying issue is now thought to be resolved.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.