JamesH1978

Results 128 comments of JamesH1978

Thankyou for submitting a PR, please can you fix the whitespace errors and line lengths so the check pass. ```RROR: White space errors ERROR: docs/SDCard_Updates.md:140: Line has trailing spaces scripts/spi_flash/spi_flash.py:34:...

more @Arksine territory, would be nice to have unique filenames to sort the issue with boards that take a different flash name every time. Not sure if there was issue...

creality is, as creality does... I am sure there was a PR mentioning it before, or i'm mistaken and it was a random chat :) but unique name generation would...

Just resurrecting this necro-pr. @mnorrsken Did you ever get anywhere with this? @Arksine This is still an issue with the stock boards like creality that need a unique file name...

thank you for submitting a PR, please refer to https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md paying particular attention to the signed-off-by line. Thanks James

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James

Thank you for submitting a PR, please refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Also please refer...

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks James