JamesH1978
JamesH1978
All PR's need signing off as mentioned in point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James
I would think a simple list of the software needed to compile firmware would be enough, then those developers wanting to only build firmware and not fully install klipper and...
Thankyou for submitting a PR, please be aware you need to sign off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James
Thank you for submitting a PR, please refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Also please refer...
Thankyou for submitting a PR, couple of points before i review, please be aware you need to sign off your PR for the certificate of origin as per point 3...
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review You also...
I agree with @Sineos it makes them harder to find for the casual user, the front ends already deal with this in their directory listings and it would also need...
These files are only created on performing a SAVE_CONFIG process, so really dont run into the many for a normal user. I am not sure there are many situations where...
Thank you for submitting a PR, as you have added a whole new config file, you will need to also submit for the regression tests as per point 4 in...
Thanks, generally it looks fine to me, although i am not sure why you have set a min_extrude_temp to 120 in both extruder configs, unless there is a good reason...