klipper icon indicating copy to clipboard operation
klipper copied to clipboard

config: added stock location of bed_screws for neptune2(s)(d)

Open dhruvinsh opened this issue 2 years ago • 2 comments
trafficstars

This config change adds stock config of the screw location. It can be found here.

dhruvinsh avatar Jan 13 '23 23:01 dhruvinsh

Hi,

Please read https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and pay particular attention to the signed off by line.

Thanks James

JamesH1978 avatar Jan 14 '23 00:01 JamesH1978

Thanks @JamesH1978 for notifying it. I have force pushed the commit and updated the commit message.

dhruvinsh avatar Jan 15 '23 17:01 dhruvinsh

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Jan 30 '23 00:01 github-actions[bot]

Thanks. The change looks fine to me, but does this printer really have 5 screws under the bed?

@just-trey - do you have any comments?

-Kevin

KevinOConnor avatar Feb 03 '23 23:02 KevinOConnor

Thank you for looking into this contribution.

No the printer does not have 5 screws. It has 4 physical screws. 5th is to provide a kind of backward compatibility of stock firmware. It serves a purpose to validate the other four screws since its location is set to the middle of the bed. If it does not seem fine then calibration can be started over and in some cases (like minute concave bed) it's very helpful.

dhruvinsh avatar Feb 03 '23 23:02 dhruvinsh

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Feb 18 '23 00:02 github-actions[bot]

Okay - seems a bit unusual to describe a fifth location, but I don't really have a particular preference. (I don't own this printer.)

-Kevin

KevinOConnor avatar Feb 18 '23 00:02 KevinOConnor

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Mar 04 '23 12:03 github-actions[bot]