JamesH1978

Results 128 comments of JamesH1978

Apologies It has taken a while for me to get back to this, looks fine except for the macros in your new file for start print and end print. Usually...

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James

Looks fine to me, but please also be aware that you need to sign off a PR, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James

@ThatColdToast if you could just add your signed off by line, we can get this approved and merged, if you are unwilling to do this, then i can go ahead...

Thanks for adding that typo change, but i still dont see a signed off by line, so i can review and accept it. Thanks James

Thankyou for submitting a PR, but the pins on a 4.2.7 are indeed different/swapped compared to a 4.2.2. This has always been the way, unless you have the "freeruns" version...

Also the mentioned config for the v2 neo also follows the 4.2.2 pin map and not the 4.2.7 one. Thanks James

Thankyou for submitting a PR, Please be aware you need to sign off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks James