Mike Perrotti

Results 115 comments of Mike Perrotti

@lindseywild @TylerJDev @joshblack - should I remove the announcements and follow @owenniblock's PVC implementation until we've figured out how to handle multiple announcements? [Comment from the PVC PR](https://github.com/primer/view_components/pull/2884#discussion_r1630926078): > I...

@TylerJDev - after talking to @joshblack, I decided to remove the announcement until we land on a solution for using `Status` in components without accidentally triggering too many announcements.

I have a path forward for preserving the top and bottom padding for buttons with wrapping lines of text. We can set the following styles on the "buttonContent" container element:...

Talked to Katie about my idea on Slack and got the go-ahead to push up changes.

This will be a draft until https://github.com/primer/react/pull/3913 is merged

@broccolinisoup - I think TreeView is actually the outlier. Here are the other components where we use a `loading` prop: - Autocomplete.Menu - Button/IconButton ([PR](https://github.com/primer/react/pull/3582)) - FilteredActionList - InlineAutocomplete -...

Updating snapshots since we updated the stories.

@strackoverflow - could you share more details about your use-case? I'm not understand why we'd need to change the color.

@siddharthkp - yes, please copy those changes over as well

@siddharthkp I'm not sure I understand your question because we set all three depending on the situation. We set `aria-label` for `IconButton` (see [Storybook example](https://primer.style/react/storybook/?path=/story/components-iconbutton--default)) We set `aria-labelledby` for either...