Mike Perrotti
Mike Perrotti
I like the flexibility of a `leadingAction`, but I can't think of other possible leading actions since we typically put actions after the item label (in a "trailing" slot). I...
@broccolinisoup - how do I run the integration tests in dotcom?
@broccolinisoup - tests are failing for `item-picker`, but I don't think it has anything to do with the changes in this PR. Have you seen this when trying to do...
I agree that we should get rid of the `contrast` prop. It's purpose was so you could have an input on a "secondary" background color (#f6f8fa) match the contrast of...
I'm worried about a default transparent background breaking designs where we're only able to reach the 3:1 contrast minimum because of the white input background. I think this use-case is...
@iansan5653 - can we add a story that demonstrates this change? Kind of like this... Alternatively, we could update all existing stories to have an expandable node that has 2...
I get a mysterious dependency error when I tried resolving the conflicts and running `npm i`: ``` npm ERR! code ERESOLVE npm ERR! ERESOLVE could not resolve npm ERR! npm...
@sunnyi101 - I suspect this was fixed when we rewrote this component's styles to be written in CSS Modules instead of `styled-components`. I can only reproduce this as a **logged...
We discussed this in today's Primer patterns working session and the designers on the call liked @dylanatsmith 's proposal to add a [grabber icon](https://primer.style/foundations/icons/grabber-16) atop the divider as an affordance.
This needs to be updated to also support tokens that use box-shadow to mimic a border (https://primer.style/foundations/primitives/color#shadow)