Mike Perrotti

Results 115 comments of Mike Perrotti

@joshblack and other reviewers - I'd really love to come to a decision with this ADR so we can fix our component prop docs. **If we reject the ADR**, I'll...

> Regarding https://github.com/primer/react/pull/4727#discussion_r1671099407, wondering just how cumbersome that would be? is it just relating to the way the components are exported as explained in the Gotchas/workarounds and adding the JSDocs...

Closing this until we revisit

> Additional documentation is present in bespoke .md files. I think we're trying to to move away from this and rely mostly on Storybook and `.docs.json` files. cc @broccolini @joshblack...

After giving it more thought, I think we _need_ to have a different react ID for the "draft" version of an existing component. They're often a full rebuild of the...

> Many of your review feedback here is specific to the contents of these bespoke .md files. Feel free to ignore that feedback so we don't blow up the scope...

In your [first Rewatch video](https://github.rewatch.com/series/51771/5xcb0rop3ildopa7) that explains our documentation infrastructure (around the 10-minute mark), you say that we shouldn't be adding content in a `{component-name}/react/{status}.mdx` file anymore. Then in your...

I completely forgot I opened this PR. Will come back to it and get it merged this week 😅

I'm waiting for the implementation to be done before getting this merged.

I'm keeping this a "draft" until https://github.com/primer/react/pull/3582 is merged and I can be assured that the styles in any screen recordings I take won't change.