view_components icon indicating copy to clipboard operation
view_components copied to clipboard

NavList::Group - `show_more_item` slot text color cannot be changed

Open strackoverflow opened this issue 2 years ago • 4 comments

There's a minor issue with the show_more_item slot in NavList::Group: the text color of the link cannot be set via system arguments as it appears to be hardcoded to :accent.

strackoverflow avatar Mar 15 '23 22:03 strackoverflow

Design first responder: are there any design concerns with changing the text color of the "Show more" nav item?

camertron avatar Mar 20 '23 22:03 camertron

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Sep 16 '23 23:09 github-actions[bot]

@strackoverflow - could you share more details about your use-case? I'm not understand why we'd need to change the color.

mperrotti avatar Sep 18 '23 16:09 mperrotti

Hi @mperrotti! Yes, our use case was that the design for GitHub's global navigation update called for a muted color scheme for the "show more items" link in the left hand side panel.

We ended up working around this, but in general I think we expected that things like text color would be customizable with system arguments. Totally a minor thing for us though.

strackoverflow avatar Sep 25 '23 21:09 strackoverflow

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Mar 25 '24 19:03 github-actions[bot]