Mike Perrotti
Mike Perrotti
Dismissing my review until we agree on a path forward from [this discussion](https://github.com/github/primer/discussions/2942)
It's worth mentioning that we use a similar component in `ActionList.Item`: https://github.com/primer/react/blob/main/src/ActionList/Item.tsx#L353
Reopening since we have a path forward for live region support: https://github.com/primer/react/pull/4313
The VRTs are failing because I removed the extra `Box` around `Dialog.CloseButton` that was creating extra space around the button. Was this extra space intentional? If so, we can bring...
Thanks for the feedback @TylerJDev - sorry I missed it. I just scheduled an a11y office hours session to discuss further: https://github.com/github/accessibility/issues/5454
@TylerJDev - during office hours I was told we're working on resolving the issues with aria live regions: https://github.com/github/accessibility/issues/4887
Just a heads-up, we just started a project to wrangle all of our different kinds of navigation. The current direction I'm exploring removes `TabNav` and `TabPanels` and just uses `UnderlineNav`...
@owenniblock - you can add feedback in the Figma or send me feedback on Slack. I also brought this to a11y office hours earlier this week https://github.com/github/accessibility/issues/5623#issuecomment-1967930432 We could still...
@joshblack - thanks for your thorough review and focus on a11y! I've tried to respond to your feedback the best I could. @langermank - take a look at my responses...
If we decide that it's ok to remove click handlers when `loading` is passed, should we also remove click handlers if `aria-disabled` is passed manually? I vote yes. What do...