Mike Perrotti
Mike Perrotti
I reverted my changes to the draft `Button` (aka `Button2`) since we talked about removing it until we're ready to switch to CSS modules. If we change our minds, it...
@ericwbailey - we haven't conditionally removed the `onClick` handlers just yet. I'm waiting for feedback on [this comment](https://github.com/primer/react/pull/3582#issuecomment-1830722517)
Good catch @pksjce! I changed the logic so the loading spinner is not rendered in the trailing visual spot when both leading and trailing visuals are passed.
@pksjce - any idea why VRT and AAT tests are failing?
@joshblack - If the button is just an action like "Export CSV", we'll need an announcement. If the button is used to submit a form, users should follow the [interface...
@ichelsea and @joshblack - I've addressed your feedback
@ichelsea - you can approve instead. I don't think it will let me merge until one of the people in the `react-reviewers` group approves 🙂
The failing VRTs don't actually seem to be broken when I preview locally. Going to update snapshots... 
~I don't know _how_, but it looks like this PR somehow fixed the issue where Dialog buttons weren't getting the right focus styles 😱~ Edit: this was not magically fixed...
@pksjce - I think we need to give some more thought to how we're handling the ConditionalWrapper stuff. Here's the discussion @langermank mentioned: https://github.com/github/primer/discussions/2942