Mike Perrotti

Results 115 comments of Mike Perrotti

Related: a SegmentedControl with icon-only buttons (which show a tooltip when hovered) needs this work to be done to be considered accessible.

Closing this PR since it's no longer needed for Passion Week demos. I'll open a new one that has the same functionality, but uses `styled-components`.

Passion week is long gone. Closing...

@siddharthkp is going to make some updates and get feedback from other teams with similar challenges. Monday Aug 15 is going to be too soon to freeze this decision cc...

Thanks for taking a look at this @siddharthkp . I couldn't think of any good workarounds with `Autocomplete.Overlay` either. Using `AnchoredOverlay` is probably the best way forward for now.

Ignore my last comment. I was able to work around this by following the [Nested Overlay](https://primer.style/react/storybook?path=/story/internal-components-overlay--nested-overlays) example in Storybook. We just need to make sure the autocomplete overlay is rendered...

@siddharthkp - I agree that 'Option 3: Opt-in composition' is the right way forward. Just a few observations: **1.** Since `IconButton` renders a tooltip by default, a Primer customer could...

This also affects the icon-only SegmentedControl buttons because they use a tooltip to show the hidden label. Instead of creating a new a11y issue for SegmentedControl, I'm including this info...

> When the component can change the selected button by itself (uncontrolled), should the prop selected be called defaultSelected instead? (like value and defaultValue for input) Yup, we should add...

Thanks again @siddharthkp! I've addressed your feedback.