Mike Perrotti
Mike Perrotti
Just a heads up - the latest Storybook deployment throws an error for the Buttons explorations: ``` ariaLabel is not defined ```
I think we're going to be changing the primer.style sidebar navigation to use [ActionList](https://primer.style/react/ActionList). If that's happening soon, we should wait until that work is done so we don't have...
Overall this is looking good, but I'd like us to align a little closer closer on the API if possible. Here's the React API for reference: https://primer-e83bf66799-13348165.drafts.github.io/drafts/SegmentedControl#props (ignore the `loading`...
I took a look at the rendered examples at https://jonrohan-primer-devspace-wr644pf5vq5-3000.githubpreview.dev/lookbook/primer/alpha/segmented_control_preview/default The way this is marked up is preventing the dividers from being shown between each button, and `:hover`/`:active` styles are...
Looking at https://primer-e5b2c477c1-26611710.drafts.github.io/components/alpha/segmentedcontrol, I'm not seeing the selected button styles.
How do I create a changeset in this repo? In primer/react I just run `npx changeset`
Thanks @colebemis - great catch with the pixel alignment!
I'm working on adding a validation example that aligns with what we defined in the interface guidelines: https://github.com/primer/react/pull/2315
@colebemis - we haven't discussed whether virtualization is in scope for v1. I think we can move forward without virtualization support for v1. When/if it comes up we'll collaborate with...
Thanks for the feedback @iansan5653 I think it makes sense to use `aria-live="polite"` to support inputs that validate as the user makes changes. I'd love to hear if somebody from...