Mike Perrotti
Mike Perrotti
It looks like we were able to get the correct buttons used in this PR: https://github.com/primer/react/pull/4049
The grid gaps are creating some spacing issues. Maybe instead of using `grid-gap`, we could just put padding on the elements in the grid. If you feel `grid-gap` is a...
@broccolinisoup - why does this have the "skip changeset" label? Wouldn't we want to cut a release with these changes?
@joshblack - I was able to address _almost_ all of your feedback. The only thing I struggled with was replacing `sx` with `className` on `SkeletonBox`.
> What did you think of the problem statement? It is clear and I've run into the challenges identified multiple times. --- > What did you think of the approach?...
> Totally get that this is confusing naming-wise and we can definitely change that, maybe to `LiveRegionProvider` and `LiveRegion` to make it more obvious? Yea, that name change makes things...
We have a major release coming up. Instead of adding a new token component, we could just modify the existing one.
I'm converting this back to a draft until we decide on a direction based on feedback in this discussion: https://github.com/github/primer/discussions/2976
The aria-live issues should be resolved by https://github.com/primer/react/pull/4174
Sorry @lindseywild - this PR got lost and stale. Going to update today. Related PVC PR: https://github.com/primer/view_components/pull/2884