Mike Perrotti
Mike Perrotti
Thanks @siddharthkp > I removed it that line and saw no changes which really confused me. I'm probably missing something very obvious here, thanks for your patience with me! I...
> I'm thinking that there are only a few options here, one being the current pattern using the aria-labelledby. We could also hide the text without using visibility: hidden, but...
@siddharthkp - do you think @TylerJDev 's suggestion will fix our problem?
@lindseywild - PR reviews would be super helpful. The only thing that would be more helpful would be to take over this PR from me and get it merged 😂
@TylerJDev and @khiga8 - I made all the requested changes. Would you mind taking another look?
These axe checks are failing because of a color change on disabled buttons: https://github.com/github/github/actions/runs/9713401583/job/26810192180?pr=331055 I'll push up a fix and open a new integration test PR.
These failures don't seem related to buttons at all: - https://github.com/github/github/actions/runs/9713401583/job/26810188969?pr=331055#step:15:10043 - https://github.com/github/github/actions/runs/9713401583/job/26810188969?pr=331055#step:15:10056
I think the failed VRT was a fluke because I tested it in local and prod Storybook, and both match what we get in the "Actual" screenshot. Going to update...
@siddharthkp @TylerJDev - I tried opening a new integration test PR with these changes, but I keep getting a mysterious failure in the `commit-and-push` job. Latest attempt: https://github.com/github/github/actions/runs/9783972307
@siddharthkp - that's what I thought too, but I don't see any PR created https://github.com/github/github/pulls?q=is%3Apr+is%3Aopen+Integration+tests+for+PRC