Mike Perrotti

Results 115 comments of Mike Perrotti

I couldn't reproduce the tiny layout shift of UnderlineNav.Item's counters and icons in a real browser, so I updated `UnderlineNav` snapshots. If anybody can reproduce, I can make more changes...

I'm not sure why the aXe tests are failing. The markup looks correct to me. @owenniblock - did you encounter anything like this with TabPanels?

Reviewers: I'll be out for 2 weeks. Please merge if this gets approved before I'm back.

Snapshots need to be updated again since we changed text in stories.

@broccolinisoup - Katie already commented, but ignore any of my comments that suggest using any of the tokens from these two pages: - https://primer.style/primitives/spacing - https://primer.style/primitives/typography There's an [ADR PR](https://github.com/github/primer/pull/1545)...

@lesliecdubs - I completely forgot about this 😅 We decided to put this example into the stories instead of the docs site. I just got distracted by other work and...

I made the update, but after talking to @ericwbailey, I'm uncertain that we'll stick with [the guidance](https://primer.style/design/ui-patterns/forms#validation-on-submit) that this change is demonstrating: > If an interactive summary of errors is...

When I brought this to a11y office hours, we decided to stick with the existing guidance. I will come back to this later this week or early next week.

Based on feedback during a11y office hours, I _think_ we to remove `aria-live` and `aria-busy`. > the react input has aria-live and aria-busy and this was reported a long time...

@josepmartins and I branched off of this and tried (and failed) to upgrade React and PRC. We're running into this issue: https://github.com/gatsbyjs/gatsby/issues/26785 Here's how we tried to get around it:...