react icon indicating copy to clipboard operation
react copied to clipboard

Adds loading state to ActionList items

Open mperrotti opened this issue 2 years ago • 5 comments

Relates to https://github.com/github/primer/issues/2681

https://github.com/primer/react/assets/2313998/2d15f422-1e1f-428e-b6ac-99e30ef4328b

Changelog

New

  • ActionList.item accepts loading prop

Changed

Removed

Rollout strategy

  • [ ] Patch release
  • [x] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [x] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [x] Changes are SSR compatible
  • [x] Tested in Chrome
  • [x] Tested in Firefox
  • [x] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

mperrotti avatar Dec 11 '23 18:12 mperrotti

🦋 Changeset detected

Latest commit: 2c2f814498de6edeccabe7911d07f9ee6f2f9c15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 11 '23 18:12 changeset-bot[bot]

This will be a draft until https://github.com/primer/react/pull/3913 is merged

mperrotti avatar Dec 11 '23 18:12 mperrotti

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.25 KB (+0.16% 🔺)
packages/react/dist/browser.umd.js 91.51 KB (+0.19% 🔺)

github-actions[bot] avatar Dec 11 '23 18:12 github-actions[bot]

@broccolinisoup - I think TreeView is actually the outlier. Here are the other components where we use a loading prop:

  • Autocomplete.Menu
  • Button/IconButton (PR)
  • FilteredActionList
  • InlineAutocomplete
  • MarkdownViewer
  • TextInput
  • ToggleSwitch

mperrotti avatar Dec 19 '23 16:12 mperrotti

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar May 05 '24 20:05 github-actions[bot]

Updating snapshots since we updated the stories.

mperrotti avatar Jul 03 '24 20:07 mperrotti