react
react copied to clipboard
Add PageHeader component
Describe your changes here.
TBD
Closes # (type the issue number after # if applicable; otherwise remove this line)
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
🦋 Changeset detected
Latest commit: 35542f8f293728997758d43dcb64a3ce845cf5e2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Name | Type |
---|---|
@primer/react | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
Path | Size |
---|---|
dist/browser.esm.js | 82.77 KB (0%) |
dist/browser.umd.js | 83.42 KB (0%) |
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.
Sorry for the delay @broccolinisoup! Left a couple of comments/notes, also had a question around alignment, should the underline nav align here?
The spacing is still very arbitrary here. I'll get it cleared with design too.
@broccolinisoup - Katie already commented, but ignore any of my comments that suggest using any of the tokens from these two pages:
- https://primer.style/primitives/spacing
- https://primer.style/primitives/typography
There's an ADR PR open that will introduce breaking changes when the names change. We can come back to these styles and use the correct tokens once they're ready.