react icon indicating copy to clipboard operation
react copied to clipboard

Updates FormControl validation example to better align with the interface guidelines

Open mperrotti opened this issue 3 years ago • 2 comments

I added a more dynamic validation example that conforms to the form validation patterns defined in the form interface guidelines.

mperrotti avatar Sep 07 '22 00:09 mperrotti

⚠️ No Changeset found

Latest commit: 72cffd701d7245e5b5a46a8ed010866a1e86d9f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 07 '22 00:09 changeset-bot[bot]

size-limit report 📦

Path Size
dist/browser.esm.js 88.82 KB (0%)
dist/browser.umd.js 89.43 KB (0%)

github-actions[bot] avatar Sep 07 '22 00:09 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Nov 06 '22 17:11 github-actions[bot]

👋🏻 @mperrotti would you still like reviews on this? Happy to get a buddy assigned if you don't want this to go stale.

lesliecdubs avatar Nov 08 '22 03:11 lesliecdubs

@lesliecdubs - I completely forgot about this 😅

We decided to put this example into the stories instead of the docs site. I just got distracted by other work and haven't come back to it yet.

I'll update today and mark as "Ready for review".

mperrotti avatar Nov 10 '22 15:11 mperrotti

I made the update, but after talking to @ericwbailey, I'm uncertain that we'll stick with the guidance that this change is demonstrating:

If an interactive summary of errors is not shown, the first invalid input should be focused and scrolled into the viewport

I'll be bringing it to next week's a11y design office hours. Then I'll either mark this PR as "Ready for review" or close it.

mperrotti avatar Nov 10 '22 18:11 mperrotti

When I brought this to a11y office hours, we decided to stick with the existing guidance. I will come back to this later this week or early next week.

mperrotti avatar Nov 30 '22 21:11 mperrotti

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Mar 26 '23 17:03 github-actions[bot]