Rhys Mainwaring

Results 197 comments of Rhys Mainwaring

> Will cherry pick the commits onto a new branch fi you don't mind Sure - no prob. I also have a branch based against `gz-sim7` as well here (https://github.com/srmainwaring/gz-sim/tree/srmainwaring/7/forceviz)...

> I think it'd be great if you opened the PR using the rebased branch. Actually this PR already uses the rebased branch (targeting `main`). I can also target `gz-sim7`...

Noticed a bug: if there are multiple instances of a plugin generating forces for the same same link, then only one will contribution will be picked up. Example: lift-drag plugin...

> @arjo129 changed the base branch from main to gz-sim7 [31 minutes ago] I'll update the branch on my side to be based in `gz-sim7` also - that will need...

> given the way git and github work it would have been impossible to determine the changes for reviewers on the PR No, it would have been fine. I'd just...

> Perhaps we should provide an option within sdf of liftdrag, buoyancy and hydrodynamics to specify``? Yeah that might work - it's not super urgent as you can introduce another...

> I can't think of a way to solve this without massive changes in other places. Perhaps we should provide an option within sdf of liftdrag, buoyancy and hydrodynamics to...

@arjo129 this branch (https://github.com/srmainwaring/gz-sim/tree/arjo/forceviz-throttled) shows how we could move the force publishing out of the Link class in a follow up PR. It adds some features that are hard to...

> Have you had a chance to take a look at the feedback? On my todo list. Apologies for the delay, I'll try to incorporate the changes in the next...

> can you fix the conflicts ? are you planning to finish this PR @srmainwaring ? Hi @ahcorde - forgot about this PR - let me review what's needed to...