Eric Robinson

Results 242 comments of Eric Robinson

If it's preferred, I can change this PR to have life steal use its own network command.

> Do you know why the game crashes? Does it have something to do with `_pmode`? It's a sprite rendering problem. I'm not sure exactly what causes it, but whatever...

> This commit modifies the weapon-type detection logic to prioritize the weapon in the player's right hand (INVLOC_HAND_RIGHT), which is conventionally the main hand. Conventionally, most players use the left...

@ArminiusTux Would you be able to try building the linked PR build and see if it fixes the original problem?

The problem appears to be a result of the fact that pregen items (items that get generated with the level) take up a slot in the delta and those slots...

Given that the cornerstone is rendered obsolete by the stash, do you think we should disable its functionality entirely, and leave it as a decorative piece?

Flamedart fixed by: https://github.com/diasurgical/DevilutionX/pull/7076 Deadly Hunter fixed by: https://github.com/diasurgical/DevilutionX/pull/3864

I believe the correct solution to this would be when rendering any objcurs graphic, to detect how many columns and rows of transparent pixels exist on all sides of the...

> > I believe the correct solution to this would be when rendering any objcurs graphic, to detect how many columns and rows of transparent pixels exist on all sides...

> > The alignment problem goes far beyond the two PRs you opened. A lot of item graphics have bad alignment and it seems weird to pick and choose specific...