Eric Robinson
Eric Robinson
Great change! Would love this
> I think this is a good change. 👍 Especially when you look at the multiplayer workaround. 🥴 > > Some questions related to the pr: > > 1. Should...
> I am unsure about the physically impossible - killing 1000 BKs per hour sounds plausible to me (with fastest speed setting). Also, it's 2 billion not 4 because it's...
Should I add a QOL toggle for this?
> side-note: #4536 also tries to use slot back colors to differ between own player and inspected player. So we should think about for what we want to use the...
> > Alternatively, one could investigate adding a black border to the items and see if that works (kind of like we did for the automap to be able to...
> The blue doesn't look too bad, but I can't bring myself to like the yellow. It's too light of a background or something, the item art blends with it...
If this concept is acceptable for DevilutionX, should I remove the switch-case and consolidate all the logic and use if-else statements to decipher between skill/spell/staff? Any suggestions?
> The concept seems pretty harmless to me. You don't necessarily have to remove the switch-case, but I would definitely recommend deduplicating much of that logic. I'll see what I...