diasurgical
Inconsistent/nonsensical effects from affixes
I'll just start this off with a couple examples.
Civerb's Cudgel/Deadly Hunter
For Civerb's Cudgel, +200% Damage to Demons is an affix that applies to total player damage rather than just the weapon damage. Taken in contrast to nearly all other +% Damage effects (see below for exceptions), this represents a special case.
For Deadly Hunter, this affix does nothing because this damage boost only applies to melee damage.
Hellfire introduced a few additional affixes with similar behavior.
- Devastation applies to total damage and does not work on bows.
- Jester's applies to total damage, but also works on bows.
- Peril applies to total damage vs monsters, but only weapon and character damage vs players. It does not work on bows.
Flamedart
This weapon includes both the Fire Arrows Damage affix and the Fire Hit Damage affix. This adds two separate +Fire Damage affixes which is confusing enough. However, Fire Hit Damage only applies to melee attacks and so it's simply an extra damage number that doesn't apply.
For Flamedart, you can utilize the melee fire damage, though in limited circumstances. You do a melee attack with a bow equipped when breaking barrels, and because of the way elemental melee damage occurs, if that broken barrel spawns a skeleton, it can be hit with the fire melee damage from the bow.
Flamedart fixed by: https://github.com/diasurgical/DevilutionX/pull/7076 Deadly Hunter fixed by: https://github.com/diasurgical/DevilutionX/pull/3864
