Eric Robinson

Results 242 comments of Eric Robinson

Can someone confirm this issue affects Lightning Wall as well?

> The reason why I've added the "insufficient information" label is because of "Observe Fire Wall derp" - the least you could do is provide a screenshot/gif :/ I'm not...

Removing the call to `CalcPlrInv()` in `RestartTownLvl()` fixes this problem completely. No noticeable side effects. Is there a reason this function needs `CalcPlrInv()`?

> Wouldn't `CalcPlrInv()` be necessary for when you die and lose items? Yeah right here: https://github.com/diasurgical/devilutionX/blob/45dbe6aa611810be103e14e503fb84b59915fa33/Source/player.cpp#L2739 And https://github.com/diasurgical/devilutionX/blob/45dbe6aa611810be103e14e503fb84b59915fa33/Source/player.cpp#L2795 Considering it calls `CalcPlrInv()` as soon as a player dies, I'm not...

I think there are 2 major issues that lead to undesirable gameplay: 1. Changing equipment can kill the player 2. Max life is allowed to go under 1 I think...

> Why not just allow the player to die in town instead? > > I feel like attempting to prevent equipment change based on the final effect of the change...

> > If an item has 0 of a property, there's no point in displaying it. We wouldn't display the armor class of a sword. > > Not the same,...

> > I think we can keep "Armor Class", it was probably borrowed from D&D: https://www.modularrealms.com/blogs/news/how-to-calculate-armor-class-in-dnd-5e > > It's still an extraneous word that conveys nothing. I also think D2...

> > I also think D2 saying "Defense" was a futile change. It's basically a "Dodge Rating" and no one wants to find heavier armor that adds to their "Dodge...

> > I've noticed that the Diablo 2 phrasing I took inspiration from seems to use "to" when the affix power adds to the player's stat sheet directly. However in...