Eric Robinson

Results 242 comments of Eric Robinson

> Why a toggle? This should be the default IMHO. Same reason Life and Mana flask values are toggles. > I'm not a fan of using blue though, it is...

> > Looks like a good option to have. Also seems like it will be easy to convert it to Lua. > > @StephenCWills Shouldn't most interface changes be (converted...

Drafting so I can convert this into a Lua PR.

I revised the description

> > Is there a reason other than "ps1 did it"? This technically doubles the work for halving or muting sound volume, so there should be a compelling reason to...

What exactly differentiates Speech from the rest of the sounds? Do monster grunts qualify as speech?

> no, grunting is music sounds. But "speech" is the live speech of the characters: both the people in the village and the quest characters in the dungeon (Butcher, imp,...

> @kphoenix137, [Diablo Evolution](https://diablo-evolution.net/index.php), which is dedicated to beta and cut content claims that a "Blood Mage" class was intended for Hellfire patch 1.02 (see the bottom of the main...

I tested these changes locally and everything passes. Not sure why all the fails.

If my PR correctly fixes this, then it's definitely a vanilla bug.