Markus Elfring
Markus Elfring
I would like to point out that identifiers like “[`_COLM_COLM_H`](https://github.com/adrian-thurston/colm/blob/28b6e0a01157049b4cb279b0ef25ea9dcf3b46ed/src/colm.h#L23-L24 "Update candidate")” and “[`__AAPL_AVLI_EL__`](https://github.com/adrian-thurston/colm/blob/28b6e0a01157049b4cb279b0ef25ea9dcf3b46ed/src/aapl/avlcommon.h#L35-L36 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [AbstractOOXmlFilePrivate](https://github.com/QtExcel/QXlsx/blob/43adfe6e40a46eb4a1fcd02eb618ffeef5ff2318/QXlsx/source/xlsxabstractooxmlfile.cpp#L18) - [Cell](https://github.com/QtExcel/QXlsx/blob/7afd9920372f12f66bdc9ad958f02ba92da96468/QXlsx/source/xlsxcell.cpp#L85)
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....
Would you like to add more error handling for return values from functions like the following? * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [usage](https://github.com/NLnetLabs/ldns/blob/631a7a66e2d882ae8aa7085def6580b37b3c7b01/examples/ldns-revoke.c#L17) * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [zones_insert](https://github.com/NLnetLabs/ldns/blob/631a7a66e2d882ae8aa7085def6580b37b3c7b01/masterdont/zones.c#L76)
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [Image](https://github.com/cnr-isti-vclab/vcglib/blob/e4950d12e2db7f6ec3e587b06b2a0474b4f08d96/img/img_image.h#L138 "Destructor for Image") - [OSGCoord](https://github.com/cnr-isti-vclab/vcglib/blob/e4950d12e2db7f6ec3e587b06b2a0474b4f08d96/wrap/opensg/vertex_component.h#L127...
I would like to point out that identifiers like “[`__VCG_PLYLIB_STUFF`](https://github.com/cnr-isti-vclab/vcglib/blob/e4950d12e2db7f6ec3e587b06b2a0474b4f08d96/wrap/ply/plystuff.h#L54 "Update candidate")” and “[`__VCGLIB_INTERSECTIONTRITRI3`](https://github.com/cnr-isti-vclab/vcglib/blob/e4950d12e2db7f6ec3e587b06b2a0474b4f08d96/vcg/space/intersection/triangle_triangle3.h#L34 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
Some parameters (like "[${Boost_INCLUDE_DIR}](https://github.com/imageworks/OpenColorIO/blob/1384029df00525c479e2c7e52fdfa294413fceb6/CMakeLists.txt#L114)" and "[${CMAKE_SOURCE_DIR}/export/](https://github.com/imageworks/OpenColorIO/blob/64adcad300adfd166280d2e7b1fb5c3ce7dca482/src/apps/ocioconvert/CMakeLists.txt#L2)") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build...
Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [QOS_XML_File_Handler](https://github.com/OpenDDS/OpenDDS/blob/ac90cef51c62d10a0fed6b5b7608a8d97dca84ad/dds/DCPS/QOS_XML_Handler/XML_File_Intf.cpp#L12-L24) - [RTDMonitorImpl](https://github.com/OpenDDS/OpenDDS/blob/ac90cef51c62d10a0fed6b5b7608a8d97dca84ad/tools/excelRTD/RTDMonitor.cpp#L34-L51)
[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the member function “Viewer::updateGraphView”](https://github.com/OpenDDS/OpenDDS/blob/ac90cef51c62d10a0fed6b5b7608a8d97dca84ad/tools/monitor/Viewer.cpp#L438-L441 "Update candidate").
[Extra null pointer checks are not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [HYPRE_LSI_BlockP](https://github.com/hypre-space/hypre/blob/e16167fe46201086f2f528b511ea94c0bb2733e2/src/FEI_mv/fei-hypre/HYPRE_LSI_blkprec.cxx#L341 "Destructor for HYPRE_LSI_BlockP") - [MLI_Solver_ARPACKSuperLU](https://github.com/hypre-space/hypre/blob/e16167fe46201086f2f528b511ea94c0bb2733e2/src/FEI_mv/femli/mli_solver_arpacksuperlu.cxx#L64 "Destructor...