Markus Elfring

Remove unnecessary null pointer checks

2

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [QueryExecutorParseQuery](https://github.com/pawelsalawa/sqlitestudio/blob/d5cd0d1d25bb872286b64da241143f536f5470ff/SQLiteStudio3/coreSQLiteStudio/db/queryexecutorsteps/queryexecutorparsequery.cpp#L12 "Destructor for QueryExecutorParseQuery") - [ReadWriteLocker](https://github.com/pawelsalawa/sqlitestudio/blob/d5cd0d1d25bb872286b64da241143f536f5470ff/SQLiteStudio3/coreSQLiteStudio/common/readwritelocker.cpp#L19...

Remove unnecessary null pointer checks

10

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [SegmentationGL](https://github.com/cnr-isti-vclab/piccante/blob/d5eeb149ac4395f4ebb028be4d96850e487138d5/include/gl/tone_mapping/segmentation_tmo_approx.hpp#L72 "Destructor for SegmentationGL") - [stdVectorClear](https://github.com/cnr-isti-vclab/piccante/blob/d5eeb149ac4395f4ebb028be4d96850e487138d5/include/util/std_util.hpp#L49...

reserved identifier violation

1

I would like to point out that an identifier like “[`_FL_PROFILE_CAT`](https://github.com/flashlight/flashlight/blob/84a6af14c978dee293ff0feb9a5ea9e4c93a6f1f/flashlight/fl/tensor/Profile.h#L45 "Update candidate")” [does eventually not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to...

I would like to point out that an identifier like “[`__PLAYERCTL_COMMON_H__`](https://github.com/altdesktop/playerctl/blob/6f4feb923eced1289b5a319d3fdefbe5ed6e3c1e/playerctl/playerctl-common.h#L20 "Update candidate")” [does not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the...

Completion of error handling

1

Would you like to [add more error handling](https://github.com/xiph/rnnoise/blob/9acc1e5a633e0961a5895a73204df24744f199b6/src/denoise.c#L272 "Update candidate: rnnoise_create()") for return values from calls of functions like [“malloc”](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation")?

Improve exception safety with smart pointers

4

Would you like to [wrap any pointers](https://github.com/harfbuzz/harfbuzz/blob/c091d029c2038de28f77d104f472b2d3bd417f0c/src/hb-directwrite.cc#L656 "Update candidate: _hb_directwrite_shape()") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?

How do you think about to [support a multiple document interface](https://doc.qt.io/qt-6/qtwidgets-mainwindows-mdi-example.html "MDI Example") for this data analysis application? :thinking:

Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [ConnectionManager](https://github.com/pentix/qjournalctl/blob/7d8047e91c01cac4ee7acb7d420fa1de803381f0/src/connectionmanager.cpp#L13) - [MainWindow](https://github.com/pentix/qjournalctl/blob/7d8047e91c01cac4ee7acb7d420fa1de803381f0/src/mainwindow.cpp#L26)

Would you like to add more error handling for return values from functions like the following? * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [MMG5_Set_inputMeshName](https://github.com/MmgTools/mmg/blob/94c6c602d3287adf52641303240a41ce0ea1a9f7/src/common/API_functionsf.c#L54) * [printf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output") ⇒ [MMG5_count_vtkEntities](https://github.com/MmgTools/mmg/blob/94c6c602d3287adf52641303240a41ce0ea1a9f7/src/common/vtkparser.cpp#L124)

I would like to point out that identifiers like “[`_INLINED_FUNCT_3D_H`](https://github.com/MmgTools/mmg/blob/94c6c602d3287adf52641303240a41ce0ea1a9f7/src/mmg3d/inlined_functions_3d_private.h#L38 "Update candidate")” and “[`_LIBMMGTYPES_H`](https://github.com/MmgTools/mmg/blob/94c6c602d3287adf52641303240a41ce0ea1a9f7/src/common/libmmgtypes.h#L34 "Another update candidate")” [do eventually not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for...