Markus Elfring
Markus Elfring
### Feature Description :eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for...
[An extra null pointer check is not needed](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") in [the function “va_DisplayContextDestroy”](https://github.com/intel/libva/blob/e4dc66b240d6d21e6546c9a21dbcfe455c8a6bff/va/glx/va_glx.c#L64-L67 "Update candidate").
:eyes: I find an implementation detail (like the following) suspicious. https://github.com/intel/libva/blob/e4dc66b240d6d21e6546c9a21dbcfe455c8a6bff/va/x11/va_dri2.c#L194-L195 How do you think about to avoid passing null pointers to resource release functions? :thinking:
Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [gz_generator::AllZeroLiteralLengthCodesConfigurator::generate()](https://github.com/intel/qpl/blob/7f56b6a8b4c0c7737c6bc8a90a2d64cfe6cec3dc/tools/utils/generators/configurators/rfc1951_stream/break_header_configurators/all_zero_literal_length_codes.cpp#L15-L35) - [gz_generator::NoLiteralLengthCodeConfigurator::generate()](https://github.com/intel/qpl/blob/7f56b6a8b4c0c7737c6bc8a90a2d64cfe6cec3dc/tools/utils/generators/configurators/rfc1951_stream/break_header_configurators/no_literal_length_code.cpp#L18-L48)
I would like to point out that identifiers like “[`_LUTS_H_`](https://github.com/rimio/libsstv/blob/ca25e0d2b7dc9d5a06be22b9b02747209abb04a3/src/luts.h#L8-L9 "Update candidate")” and “[`_SSTV_H_`](https://github.com/rimio/libsstv/blob/ca25e0d2b7dc9d5a06be22b9b02747209abb04a3/src/sstv.h#L8-L9 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
I suggest to reuse a higher level build system so that powerful checks for software features will become easier. - [CMake](https://cmake.org/ "Building software with CMake") - [Autotools](https://www.gnu.org/software/autoconf/autoconf.html#introduction "Building software with...
:eyes: [I took another look](https://lore.kernel.org/smatch/[email protected]/ "Clarification request from 2024-03-18") also at [the implementation of the macro “sql_insert_helper”](https://github.com/error27/smatch/blob/2fb2b9093c5d001c7fd3ea58fe533df880dd2c44/smatch.h#L1131-L1166 "Update candidate"). I got the impression then that such data processing can benefit...
Would you like to add more error handling for return values from functions like the following? * [fclose](https://pubs.opengroup.org/onlinepubs/9799919799/functions/fclose.html "Close a stream.") ⇒ [show_tags](https://github.com/error27/smatch/blob/2fb2b9093c5d001c7fd3ea58fe533df880dd2c44/ctags.c#L101) * [malloc](https://pubs.opengroup.org/onlinepubs/9799919799/functions/malloc.html "Memory allocation") ⇒ [register_state_assigned](https://github.com/error27/smatch/blob/2fb2b9093c5d001c7fd3ea58fe533df880dd2c44/smatch_state_assigned.c#L102) *...
I would like to point out that identifiers like “[`__in_fake_assign`](https://github.com/error27/smatch/blob/2fb2b9093c5d001c7fd3ea58fe533df880dd2c44/smatch.h#L699 "Update candidate")” and “[`__print_cur_stree`](https://github.com/error27/smatch/blob/2fb2b9093c5d001c7fd3ea58fe533df880dd2c44/smatch_states.c#L72-L75 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the...
I would like to point out that an identifier like “[`__GA_SERVICE_RESOLVER_H__`](https://github.com/avahi/avahi/blob/6d801ab52fd10aa6a204152b5d69aea62eef5028/avahi-gobject/ga-service-resolver.h#L20-L21 "Update candidate")” [does not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the...