Markus Elfring
Markus Elfring
Would you like to [wrap any pointer data members](https://github.com/szechyjs/dsd/blob/290a2204ba2a579bb32a1fb95d4c2a4683e8f770/include/ReedSolomon.hpp#L132 "Update candidate: ReedSolomon_63 class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
[A few test cases](https://github.com/namhyung/uftrace/blob/55ee3007c44ff1c833b166ff5256201011137f66/uftrace.c#L1024 "Specification of test cases") are also stored in the source file for the main program. Would it be a bit better to store them as separate...
Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [CData](https://github.com/stuntrally/stuntrally/blob/9c43322f6b788871025bd0d10f7c768819dd2c17/source/ogre/common/data/CData.cpp#L141) - [CScene](https://github.com/stuntrally/stuntrally/blob/37c19122ed9087317167d3c32df5523ebb9f5102/source/ogre/common/CScene.cpp#L14)
[Extra null pointer checks are not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the function “Events::destroy”](https://github.com/zerotier/libzt/blob/613c7e8f91cf83b993524a8f4ca9b883937331c2/src/Events.cpp#L151 "Update candidate").
Would you like to add more error handling for return values from functions like the following? * [printf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output.") ⇒ [usage](https://github.com/NLnetLabs/unbound/blob/785c938106dbbfb2d5d93d4ee49cf4d34c04dcf5/smallapp/unbound-control.c#L89) * [strdup](https://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html "Duplicate a string.") ⇒ [readup_str](https://github.com/NLnetLabs/unbound/blob/a64cbe958dacb2cafe2800587fd76154371a464b/testcode/lock_verify.c#L163)
Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [ConjugueGradient](https://github.com/FreeFem/FreeFem-sources/blob/1312e9d9c06fec8d3d49f1452df6f951901d85c9/src/femlib/CG.cpp#L195) - [Transfo_Mesh3](https://github.com/FreeFem/FreeFem-sources/blob/a7d3089c6dd756242fb978bd9a1e0cf290eeb793/plugin/seq/TransfoMesh_v2.cpp#L51) - [Triangles::gibbs](https://github.com/FreeFem/FreeFem-sources/blob/a7d3089c6dd756242fb978bd9a1e0cf290eeb793/src/bamglib/Meshgibbs.cpp#L959)
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [ISingleton::releaseInstance](https://github.com/famez/J1939-Framework/blob/3b8456697d7795cafcb39a60379fdc6f90a57c47/Common/include/Singleton.h#L72 "ISingleton::releaseInstance function") - [J1939Factory::unregisterAllFrames](https://github.com/famez/J1939-Framework/blob/3b8456697d7795cafcb39a60379fdc6f90a57c47/J1939/J1939Factory.cpp#L37 "J1939Factory::unregisterAllFrames...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [NodeScene::resetPreset](https://github.com/zenustech/zeno/blob/3bfb2eb4ad27dc85d16b34a4fc68f2f8ec1ac55d/ui/zenodesign/nodescene.cpp#L60 "NodeScene::resetPreset function") - [ResizableImageItem::resetImage](https://github.com/zenustech/zeno/blob/3bfb2eb4ad27dc85d16b34a4fc68f2f8ec1ac55d/ui/zenodesign/resizecoreitem.cpp#L81 "ResizableImageItem::resetImage...
I would like to point out that identifiers like “[`__DESIGNER_COMMON_ID_H__`](https://github.com/zenustech/zeno/blob/6e18b80ffd6dd07ed355c1209db2c58014bc0a21/ui/zenoui/render/common_id.h#L1 "Update candidate")” and “[`__NODESYS_COMMON_H__`](https://github.com/zenustech/zeno/blob/72d0ae710b5aaea0e4d31935e03b1cb58d1b6e56/ui/zenoui/nodesys/nodesys_common.h#L1 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [tracing_uninit](https://github.com/fraunhoferhhi/vvdec/blob/ac6cbc0b2b857e6f39b89ad6b59a94af796d23d8/source/Lib/CommonLib/dtrace_next.h#L159 "tracing_uninit function") - [VVDecImpl::vvdec_frame_reset](https://github.com/fraunhoferhhi/vvdec/blob/ac6cbc0b2b857e6f39b89ad6b59a94af796d23d8/source/Lib/vvdec/vvdecimpl.cpp#L1531 "VVDecImpl::vvdec_frame_reset...