Markus Elfring
Markus Elfring
Would you like to add more error handling for return values from functions like the following? * [fclose](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html "Close a stream.") ⇒ [stbi_write_png](https://github.com/nothings/stb/blob/03f50e343d796e492e6579a11143a085429d7f5d/stb_image_write.h#L1225) * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output.") ⇒ [main](https://github.com/nothings/stb/blob/03f50e343d796e492e6579a11143a085429d7f5d/tools/make_readme.c#L57)...
Would you like to add more error handling for return values from functions like the following? * [fseek](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html "Reposition a file-position indicator") ⇒ [mpc_input_rewind](https://github.com/orangeduck/mpc/blob/7c910e9303833c349f7432188ff77f2745254df2/mpc.c#L348) * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [mpc_input_new_string](https://github.com/orangeduck/mpc/blob/7c910e9303833c349f7432188ff77f2745254df2/mpc.c#L103)...
:thought_balloon: I find that an include guard like “[`mpc_h`](https://github.com/orangeduck/mpc/blob/ddcdd4d80110f16a1f3d0ee6038d5c5c789ebcf6/mpc.h#L10 "Update candidate")” is too short for the safe reuse of your header file (when it belongs to an application programming interface).
:thinking: Would you like to [fix an example for unified diffs according to a commit review](https://github.com/rshariffdeen/FixMorph/commit/db1171244fa133f92b9a1274749a2e4368e18402#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R98 "Update docs/helpers for unified format")?
I have noticed that [plus operators were specified between string literals of Python source code](https://github.com/rshariffdeen/FixMorph/blob/db1171244fa133f92b9a1274749a2e4368e18402/app/tools/emitter.py#L185 "Update candidate"). I find such specifications unnecessary because [the programming language “Python” supports such concatenation...
Would you like to add more error handling for return values from functions like the following? - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output.") ⇒ [help](https://github.com/xoreaxeaxeax/sandsifter/blob/dff63246fed84d90118441b8ba5b5d3bdd094427/injector.c#L1195) - [pthread_mutex_init](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html "Initialize a mutex.") ⇒ [main](https://github.com/xoreaxeaxeax/sandsifter/blob/dff63246fed84d90118441b8ba5b5d3bdd094427/injector.c#L1385)
Would you like to wrap any pointer data members with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [TensorC class](https://github.com/ap-hynninen/cutt/blob/4c251c60e38f9c8a61a9ebbb3630d8ab01ba9da1/src/cuttplan.cpp#L139) - [TensorTester class](https://github.com/ap-hynninen/cutt/blob/4c251c60e38f9c8a61a9ebbb3630d8ab01ba9da1/src/TensorTester.cu#L105)
I would like to point out that identifiers like "[`_ALIGNER_H_`](https://github.com/redpony/cdec/blob/b8f314dddda3d440164e4772830e3c951ba06ee4/decoder/aligner.h#L1)" and "[`_HG_H_`](https://github.com/redpony/cdec/blob/d033a045aa46ff876ad2c9f6929e2095b2481cdf/decoder/hg.h#L1)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to adjust...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null) like the following. - [Scene::AllocateVBO](https://github.com/PixarAnimationStudios/OpenSubdiv/blob/335596236b2d7857a0a4f9ead94765ff11eb8086/examples/glShareTopology/scene.h#L83) - [GLDrawConfig](https://github.com/PixarAnimationStudios/OpenSubdiv/blob/335596236b2d7857a0a4f9ead94765ff11eb8086/examples/common/glShaderCache.cpp#L38)
Would you like to add more error handling for return values from functions like the following? - [fprintf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html) ⇒ [generate](https://github.com/PixarAnimationStudios/OpenSubdiv/blob/aa324d32c316d862b8dcb25d64112688e65e7ccb/regression/hbr_regression/baseline.cpp#L102) - [fseek](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html) ⇒ [readShape](https://github.com/PixarAnimationStudios/OpenSubdiv/blob/335596236b2d7857a0a4f9ead94765ff11eb8086/regression/hbr_regression/main.cpp#L109)