Markus Elfring
Markus Elfring
I would like to point out that identifiers like “[`_AST_DECL_AST_DECL_HH`](https://github.com/DOCGroup/ACE_TAO/blob/efc29cab7d36fd23b9d97670baedfb06d562154a/TAO/TAO_IDL/include/ast_decl.h#L66-L67 "Update candidate")” and “[`_COMM_MANAGER_H`](https://github.com/DOCGroup/ACE_TAO/blob/efc29cab7d36fd23b9d97670baedfb06d562154a/ACE/apps/drwho/Comm_Manager.h#L12-L13 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
Would you like to add more error handling for return values from functions like the following? * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [GWION_IMPORT(compile_file)](https://github.com/Gwion/Gwion/blob/b95326423602bd29102b1a0f2b212b21e54d6f86/tests/plug/compile_file.c#L15) * [fread](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fread.html "Binary input") ⇒ [SFUN(string_load)](https://github.com/Gwion/Gwion/blob/faf08cc1b8bf3b1ce54cb39813aba5f98700c1b5/src/lib/string.c#L374)
:eyes: [Some functions “main” are provided](https://github.com/cnr-isti-vclab/nexus/search?l=C%2B%2B&q=main "Update candidates"). :thought_balloon: I suggest to [move code parts into member functions](https://refactoring.com/catalog/extractClass.html "Extract a class") of [corresponding application objects](https://doc.qt.io/qt-6/qcoreapplication.html#details "Using QCoreApplication classes").
I noticed (in the source code) that objects were thrown based on following data types. * `char const *` * `QString` * `std::string` :thought_balloon: I suggest to use other classes...
:thought_balloon: Would you like to [wrap any pointers](https://github.com/cnr-isti-vclab/nexus/blob/e30c749dada35870b02b27d9390e914cd18d9a32/src/nxsbuild/objloader.cpp#L366 "Update candidate: ObjLoader::getTriangles()") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [main](https://github.com/cnr-isti-vclab/nexus/blob/f7d96dd388ab22f5d2064374f1fc7ec9fc6c1329/src/nxsbuild/main.cpp#L310 "main function") - [StaticModel](https://github.com/cnr-isti-vclab/nexus/blob/8e9d1fb7b8e6cb5a25131941e2d67530b8aa38b2/src/nxszip/model.h#L54 "Destructor...
Would you like to add more error handling for return values from functions like the following? * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output.") ⇒ [wasmCWriteFreeFunction](https://github.com/turbolent/w2c2/blob/020c5a1c74522995f7e70302b9707a227c65f545/w2c2/c.c#L4501) * [fseek](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html "Reposition a file-position indicator") ⇒...
:thought_balloon: I suggest to add more [namespaces](https://en.wikipedia.org/w/index.php?title=Namespace#Use_in_common_languages "Use in common languages") to the source files of your class library. Would you like to [reduce the probability for name clashes](https://en.cppreference.com/w/cpp/language/namespace "Documentation")?...
Would you like to replace more defines for constant values by [enumerations](https://en.wikipedia.org/wiki/Enumerated_type#C_and_syntactically_similar_languages "Description for enumerated types") to stress their relationships? - [`COLM_RN_`…](https://github.com/adrian-thurston/colm/blob/28b6e0a01157049b4cb279b0ef25ea9dcf3b46ed/src/colm.h#L116-L119) - [`IN_`…](https://github.com/adrian-thurston/colm/blob/28b6e0a01157049b4cb279b0ef25ea9dcf3b46ed/src/bytecode.h#L41-L345) - [`PCR_`…](https://github.com/adrian-thurston/colm/blob/28b6e0a01157049b4cb279b0ef25ea9dcf3b46ed/src/pdarun.h#L431-L436)
Would you like to add more error handling for return values from functions like the following? * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [new_seq_buf](https://github.com/adrian-thurston/colm/blob/28b6e0a01157049b4cb279b0ef25ea9dcf3b46ed/src/input.c#L75) * [printf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output.") ⇒ [print_pattern](https://github.com/adrian-thurston/colm/blob/28b6e0a01157049b4cb279b0ef25ea9dcf3b46ed/grammar/pcre/pcre.rl#L828) *...