QXlsx icon indicating copy to clipboard operation
QXlsx copied to clipboard

Improve exception safety with smart pointers

Open elfring opened this issue 2 years ago • 1 comments

Would you like to wrap any pointers with the class template “std::unique_ptr”?

Update candidates:

elfring avatar Dec 27 '22 15:12 elfring

std::make_shared brings some perf improvement, I'd rather just remove the if(ptr) as delete nullptr is harmless; unique_ptr doesn't always play well with forwarded private classes

dantti avatar Dec 27 '22 16:12 dantti