Markus Elfring

:thought_balloon: I find that include guards like “[`DTL_H`](https://github.com/cubicdaiya/dtl/blob/831aeecf1f8afa08cd9c24677f389183f6834876/dtl/dtl.hpp#L36)” and “[`DTL_SES_H`](https://github.com/cubicdaiya/dtl/blob/831aeecf1f8afa08cd9c24677f389183f6834876/dtl/Ses.hpp#L38)” are too short for the safe reuse of your header files (when they belong to an application programming interface).

Remove unnecessary null pointer checks

15

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [nnef_graph_release](https://github.com/KhronosGroup/NNEF-Tools/blob/ac3f990b1f726479694ec7368965294892122169/parser/cpp/src/cnnef.cpp#L48 "nnef_graph_release function") - [nnef_tensor_release](https://github.com/KhronosGroup/NNEF-Tools/blob/ac3f990b1f726479694ec7368965294892122169/parser/cpp/src/cnnef.cpp#L167 "nnef_tensor_release...

reserved identifier violation

6

I would like to point out that identifiers like “[`_CNNEF_H_`](https://github.com/KhronosGroup/NNEF-Tools/blob/ac3f990b1f726479694ec7368965294892122169/parser/cpp/include/cnnef.h#L17 "Update candidate")” and “[`_NNEF_FRAGMENT_H_`](https://github.com/KhronosGroup/NNEF-Tools/blob/ac3f990b1f726479694ec7368965294892122169/parser/cpp/include/nnef/comp/fragment.h#L17 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...

reserved identifier violation

1

I would like to point out that identifiers like “[`‎_MESH_GLUE_‎`](https://github.com/apache/mynewt-nimble/blob/10b3aa043ef7c2c023cd9418b5f35e40e07bb34f/nimble/host/mesh/include/mesh/glue.h#L20 "Update candidate")” and “[`‎__MODEL_CLI_H__‎`](https://github.com/apache/mynewt-nimble/blob/10b3aa043ef7c2c023cd9418b5f35e40e07bb34f/nimble/host/mesh/include/mesh/model_cli.h#L7 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the...

:thought_balloon: I find the implementation for a function like [json_object_init()](https://github.com/kgabis/parson/blob/1314bf8ad6f22edd2feb9d8c867756f41db21f2a/parson.c#L433 "Update candidate") improvable. * Further memory areas should only be allocated if previous allocations succeeded. * Would you like to...

:thought_balloon: Would you like to [add more error handling](https://github.com/kgabis/parson/blob/1314bf8ad6f22edd2feb9d8c867756f41db21f2a/parson.c#L203 "Update candidate: read_file()") for [return values from used functions](https://wiki.sei.cmu.edu/confluence/display/c/EXP12-C.+Do+not+ignore+values+returned+by+functions "Do not ignore values returned by functions")? :crystal_ball: How will chances evolve...

reserved identifier violation

2

I would like to point out that identifiers like “[`_INPUT_DATA`](https://github.com/adrian-thurston/ragel/blob/65540b65ff09330b0293423e3fecc44e63f30614/src/inputdata.h#L23-L24 "Update candidate")” and “[`_NRAGEL_H`](https://github.com/adrian-thurston/ragel/blob/65540b65ff09330b0293423e3fecc44e63f30614/src/nragel.h#L1-L2 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...

[An extra null pointer check is not needed in a function](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like [the destructor for the class “String”](https://github.com/kacperks/Fractal_Engine/blob/1a57ee8831752c94e8471f73de637849a796791c/Engine/Source/Core/String.h#L64 "Update candidate").

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [Engine::Shutdown](https://github.com/flingengine/FlingEngine/blob/092c1506c2a024cdb8dcc0642fabc183d5f3db9f/FlingEngine/Core/src/Engine.cpp#L113 "Engine::Shutdown function") - [MeshRenderer::Release](https://github.com/flingengine/FlingEngine/blob/092c1506c2a024cdb8dcc0642fabc183d5f3db9f/FlingEngine/Graphics/src/MeshRenderer.cpp#L30 "MeshRenderer::Release...

reserved identifier violation

3

I would like to point out that identifiers like “[`_MATRIX_UTILS_H_`](https://github.com/ARM-software/CMSIS-DSP/blob/99e15d3d95084b6868c5579b6791aff5cbeefcd6/Include/dsp/matrix_utils.h#L27-L28 "Update candidate")” and “[`_TRANSFORM_FUNCTIONS_H_`](https://github.com/ARM-software/CMSIS-DSP/blob/99e15d3d95084b6868c5579b6791aff5cbeefcd6/Include/dsp/transform_functions.h#L27-L28 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...