Markus Elfring

Would you like to add more error handling for return values from functions like the following? - [fseek](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html "Reposition a file-position indicator.") ⇒ [Preprocessor::preprocess](https://github.com/WerWolv/ImHex/blob/3827919a32462f49ee882b42db99ec5ae0830c0d/source/lang/preprocessor.cpp#L56) - [ftell](https://pubs.opengroup.org/onlinepubs/9699919799/functions/ftell.html "Return a file offset.")...

reserved identifier violation

1

I would like to point out that identifiers like “[`_IP2REGION_H`](https://github.com/lionsoul2014/ip2region/blob/e26ed448618aea6d01f36ed4761dc6c235534c9e/binding/c/ip2region.h#L7 "Update candidate")” and “[`__PRINT_ABOUT__`](https://github.com/lionsoul2014/ip2region/blob/1b275b49da8b8066772a6cb93d494c133868af70/binding/c_mmap/testSearcher.c#L14 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler...

Would you like to add more error handling for return values from functions like the following? - [alloc_node](https://github.com/armon/libart/blob/cfcdc23d5b7a3d6d53f96156f20a718c704e6375/src/art.c#L16) ⇒ [add_child48](https://github.com/armon/libart/blob/cfcdc23d5b7a3d6d53f96156f20a718c704e6375/src/art.c#L352) - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [make_leaf](https://github.com/armon/libart/blob/cfcdc23d5b7a3d6d53f96156f20a718c704e6375/src/art.c#L322)

Completion of error handling

2

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [elf32](https://github.com/jserv/amacc/blob/6de68552cab3cf18771fe03a29f627518d4a5c42/amacc.c#L1082) - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output") ⇒ [next](https://github.com/jserv/amacc/blob/6de68552cab3cf18771fe03a29f627518d4a5c42/amacc.c#L98)

Fix signal handler

2

The function "[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html)" does not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your function "[sig](https://github.com/jserv/facebooc/blob/7ff378def4b3d48f66e52c4340320fdefcb420fd/src/main.c#L21)".

Would you like to add more error handling for return values from functions like the following? - [ftell](http://pubs.opengroup.org/onlinepubs/9699919799/functions/ftell.html) ⇒ [templateRender](https://github.com/jserv/facebooc/blob/cdfaa9ff7ccb065cdca79f4ec91a990d50149092/src/template.c#L32) - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [serverNew](https://github.com/jserv/facebooc/blob/6e5505b4e9620822dcbd751e36a007936ebc9401/src/server.c#L63)

I would like to point out that identifiers like "[`__SHOTGUN_COMMON_`](https://github.com/akyrola/shotgun/blob/da03d6af56853be07dd972974c96f2a7821d4f06/common.h#L23)" and "[`_CAS_ARRAY_`](https://github.com/akyrola/shotgun/blob/da03d6af56853be07dd972974c96f2a7821d4f06/cas_array.h#L23)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to adjust...

Would you like to [add more error handling](https://github.com/blechschmidt/massdns/blob/8df0535154d67f21626c039f7e43666965aef758/main.c#L178) for [return values from functions like "fprintf"](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html)?

Remove an unnecessary null pointer check

1

[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the function “TriggerObject::PutTriggerInGui”](https://github.com/enginmanap/limonEngine/blob/8567ffe80456d59be227fa520da3dfe944653a2e/src/GameObjects/TriggerObject.cpp#L87 "Update candidate").

Improve exception safety with smart pointers

1

Would you like to wrap any pointer data members with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [AIMovementGrid](https://github.com/enginmanap/limonEngine/blob/7592add69db5dd715aaf16f4949ce58f933a3ca2/src/AI/AIMovementGrid.h#L66) - [TriggerObject](https://github.com/enginmanap/limonEngine/blob/ae78995529acf89aac477d754a2b9090ddabf66b/src/GameObjects/TriggerObject.h#L40)