Markus Elfring
Markus Elfring
[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the function “lc_i_free_interactive_controller”](https://github.com/meshula/LabCamera/blob/5e6f0cf53558a3eb99972c48be628c9da4a24777/cpp/LabCamera.cpp#L701 "Update candidate").
Would you like to add more error handling for return values from functions like the following? * [fopen](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html "Open a stream") ⇒ [do_save](https://github.com/mintsuki/fvwm95/blob/93534427893b2e6f93c2612c8e9d82ec82cb07aa/modules/FvwmSave/FvwmSave.c#L295) * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [SendFvwmPipe](https://github.com/mintsuki/fvwm95/blob/93534427893b2e6f93c2612c8e9d82ec82cb07aa/modules/FvwmBacker/FvwmBacker.c#L266)
[An extra null pointer check is not needed in functions](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") like the following. - [ComplexFunction](https://github.com/mintsuki/fvwm95/blob/93534427893b2e6f93c2612c8e9d82ec82cb07aa/fvwm/complex.c#L92) - [GetConfigLine](https://github.com/mintsuki/fvwm95/blob/93534427893b2e6f93c2612c8e9d82ec82cb07aa/libs/GetLine.c#L21)
I would like to point out that identifiers like “[`_DECORATIONS_H_`](https://github.com/mintsuki/fvwm95/blob/93534427893b2e6f93c2612c8e9d82ec82cb07aa/include/decorations.h#L5-L6 "Update candidate")” and “[`__Goodies__`](https://github.com/mintsuki/fvwm95/blob/93534427893b2e6f93c2612c8e9d82ec82cb07aa/modules/FvwmTaskBar/Goodies.h#L1-L2 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not declare an identifier which is reserved for the...
[The information “…, returning the results through a shared memory area to the parent process, …” is provided](https://github.com/rdicosmo/parmap/blob/963608763589e03de38e744d359884d491e65460/README.md?plain=1#L24 "Documentation"). This hint refers to output data. :thinking: * How do you...
The following information is provided in [the section “Preservation of output order in Parmap”](https://github.com/rdicosmo/parmap/blob/963608763589e03de38e744d359884d491e65460/README.md?plain=1#L63 "Documentation"). * _No reordering logic is implemented for `parmapfold`, `parfold` and their variants,_ :crystal_ball: Will the...
:thought_balloon: I find that an include guard like “[`VINA_H`](https://github.com/ccsb-scripps/AutoDock-Vina/blob/d13f9e93e253573b01ffbb28cfd1e2dd26ff9002/src/lib/vina.h#L23 "Update candidate")” is too short for the safe reuse of your header file (when it belongs to an application programming interface).
[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the member function “MainWindow::setTrayIconEnabled”](https://github.com/Lurkki14/tuxclocker/blob/645fe98e9b5580f06623d0fc12b6075728b4ba4d/src/tuxclocker-qt/MainWindow.cpp#L113 "Update candidate").
I would like to point out that a prefix like “[`cmdf__`](https://github.com/ronen25/libcmdf/blob/3c845325a4439eb3581853e812849151abaefade/libcmdf.h#L130 "Update candidate")” [does eventually not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to...
Would you like to add more error handling for return values from functions like the following? * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [cmdf__print_title](https://github.com/ronen25/libcmdf/blob/3c845325a4439eb3581853e812849151abaefade/libcmdf.h#L298) * [fputc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fputc.html "Put a byte on a...