Markus Elfring
Markus Elfring
Would you like to [add more error handling](https://github.com/WetDesertRock/Yarn/blob/1b17d2182a7d3a72e13891bdde19b50ef7030594/src/yarn.c#L602) for return values from [functions like "ftell"](http://pubs.opengroup.org/onlinepubs/9699919799/functions/ftell.html)?
Some parameters (like "[${DIR_ROOT}/intern](https://github.com/sahib/glyr/blob/921b5bb55a075ae325e078bcc2ad81b92201c832/CMakeLists.txt#L106)") are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if...
Would you like to add more error handling for return values from functions like the following? - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [makeHeader](https://github.com/gpakosz/peg/blob/74b7881f93ea9d2df51931debba10770b7fa9cbc/src/leg.leg#L190) - [strdup](https://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html "Duplicate a string.") ⇒ [makeRule](https://github.com/gpakosz/peg/blob/74b7881f93ea9d2df51931debba10770b7fa9cbc/src/tree.c#L51)
I suggest to reuse a higher level build system than your current small [Make file](https://github.com/seenaburns/stag/blob/2ec34a9aef93caa3ca257d60cf982be39a6f5c66/Makefile#L1) so that powerful checks for software features will become easier. - [CMake](http://cmake.org/) - [Autotools](http://www.gnu.org/software/autoconf/#TOCintroduction)
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
I would like to point out that identifiers like "[`DLIB_CBLAS_CONSTAnTS_H__`](https://github.com/thomwolf/Magic-Sand/blob/90ce11558d2b34d0cde4c3e0cb98df3d3da6b74c/src/KinectProjector/libs/dlib/matrix/cblas_constants.h#L3)" and "[`__GreatSand__SandSurfaceRenderer__`](https://github.com/thomwolf/Magic-Sand/blob/60138614b9519fad3de2f75ad0037a954db7118d/src/SandSurfaceRenderer/SandSurfaceRenderer.h#L26)" [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to...
[Extra null pointer checks are not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the function “CTemporalFrameFilter::ClearData”](https://github.com/thomwolf/Magic-Sand/blob/a5f88d707e2050455e4f2935e6aa4e8e0835059b/src/KinectProjector/TemporalFrameFilter.cpp#L121 "Update candidate").
[A specific header file](https://github.com/thomwolf/Magic-Sand/blob/60138614b9519fad3de2f75ad0037a954db7118d/src/SandSurfaceRenderer/SandSurfaceRenderer.h#L34) declares two classes after the scope was closed for [an include guard](https://en.wikipedia.org/wiki/Include_guard). I suggest to move the preprocessor statement "`#endif`" to the end of such a...
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
I would like to point out that identifiers like “[`LUG_HPP__`](https://github.com/jwtowner/lug/blob/490ee5e9df76c963b47752b78e7df697f5f8d5f0/lug/lug.hpp#L5 "Update candidate")” and “[`LUG_DETAIL_HPP__`](https://github.com/jwtowner/lug/blob/1820fe72ba4f2361bbe884fd6f500c7d661cac79/lug/detail.hpp#L5 "Another update candidate")” [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for...