Markus Elfring

Remove unnecessary null pointer checks

6

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [EncAdaptiveLoopFilter::destroy](https://github.com/fraunhoferhhi/vvenc/blob/6df066883cf52a4a0faf7be5eb6f0e572afedf34/source/Lib/EncoderLib/EncAdaptiveLoopFilter.cpp#L1508 "EncAdaptiveLoopFilter::destroy function") - [EncLib](https://github.com/fraunhoferhhi/vvenc/blob/6df066883cf52a4a0faf7be5eb6f0e572afedf34/source/Lib/EncoderLib/EncLib.cpp#L90 "Destructor...

Identifying code quality issues e.g. unnecessary null pointer checks

8

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [AccessPointImpl::config](https://github.com/SmingHub/Sming/blob/112da39f9d718a37e937de8825f6faf4a1c45cc1/Sming/Components/Network/Arch/Esp8266/Platform/AccessPointImpl.cpp#L85 "AccessPointImpl::config function") - [doUpgrade](https://github.com/SmingHub/Sming/blob/2345c3e8aacd94af917441f93f55e9a60dd7cee3/samples/Basic_Ota/app/application.cpp#L51 "doUpgrade...

Completion of error handling

21

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...

Improve exception safety with smart pointers

2

Would you like to [wrap any pointer data members](https://github.com/QuasarApp/CQtDeployer/blob/e8789df5df3990fc95a173d9ce160b32dd030d86/src/Deploy/src/deploy.cpp#L16 "Update candidate: Deploy class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?

Would you like to add more error handling for return values from functions like the following? * [fclose](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html "Close a stream") ⇒ [MVM_jit_dump_bytecode](https://github.com/MoarVM/MoarVM/blob/d11bd7f11aa6661d6c09b3284bee6d3931bb3508/src/jit/dump.c#L5) * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [serializeTelemetryBufferRange](https://github.com/MoarVM/MoarVM/blob/4b2de6d1d09f3e87a91b829fed91d41089252432/src/profiler/telemeh.c#L235)

Increase the usage of combined assignment operators

2

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....

Remove unnecessary null pointer checks

3

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [ShapeManager](https://github.com/vircadia/vircadia/blob/cd2d6847ee8a042cc469872a8a8b815c817c080a/libraries/physics/src/ShapeManager.cpp#L26 "Destructor for ShapeManager") - [SharedObject](https://github.com/vircadia/vircadia/blob/cd2d6847ee8a042cc469872a8a8b815c817c080a/libraries/qml/src/qml/impl/SharedObject.cpp#L82...

Would you like to add more error handling for return values from functions like the following? * [fopen](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html "Open a stream") ⇒ [write_file_ascii](https://github.com/LingDong-/wax/blob/2456907897cdf749674c1c3ed080da425cbab738/src/parser.c#L273) * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [list_add_no_reg](https://github.com/LingDong-/wax/blob/92172a55870412d211963110cacababe890885c3/src/common.c#L53)

Remove unnecessary null pointer checks

2

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [Landusemap](https://github.com/RigsOfRods/rigs-of-rods/blob/5fdddb4d258c975d23e0c5edde2d471e3d82c818/source/main/gameplay/Landusemap.cpp#L51 "Destructor for Landusemap") - [MovableText](https://github.com/RigsOfRods/rigs-of-rods/blob/5fdddb4d258c975d23e0c5edde2d471e3d82c818/source/main/gfx/MovableText.cpp#L67...

:eyes: I am looking for ways to get [representations of function call trees](https://en.wikibooks.org/wiki/Visualizing_Computation/Call_Trees "Documentation") generated also from OCaml source code. How do you think about to improve programming interfaces and...