ACE_TAO icon indicating copy to clipboard operation
ACE_TAO copied to clipboard

reserved identifier violation

Open elfring opened this issue 1 year ago • 3 comments

I would like to point out that identifiers like “_AST_DECL_AST_DECL_HH” and “_COMM_MANAGER_Hdo not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

elfring avatar Oct 29 '23 10:10 elfring

There are uses of preprocessor identifiers (and probably others) that do not conform to what the standard requires because they're reserved. I think a contribution to change this would be welcome.

mitza-oci avatar Oct 31 '23 16:10 mitza-oci

:thought_balloon: Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

elfring avatar Nov 01 '23 11:11 elfring

Feel free to use a tool to make a proposed pull request

jwillemsen avatar Nov 01 '23 11:11 jwillemsen