Dominik G.

looks like this recent change broke the fallback and expects the global to be set always, which isn't the case in vitest env https://github.com/sveltejs/kit/pull/11601/files#diff-beef34c36ed87d7835d0166655010910fba9949a6ef95042cb468d7d73423816R427 leading to ```bash TypeError: Cannot read...

workaround to stub it via vitest, use vites own tooling to load an env config and supply the public prefixes to globalThis.__sveltekit_dev. Note that this is a workaround, and the...

Love that there are multiple providers from the start :heart: One thing to note is that the adapter config hook is also new. Was that added to kit before or...

Are you building for safari12? sveltekit 1.0 uses vite 4.0 which defaults to safari14 as minimum target. And iirc safari

for vite config it's a matter of taste, as vite bundles it on the fly either way (not great imho, but it is what it is). svelte config otoh always...

yes it is, https://vitejs.dev/config/ > Vite also directly supports TS config files. You can use vite.config.ts with the defineConfig helper as well.

vite-pwa is already mentioned in our docs https://kit.svelte.dev/docs/service-workers , last paragraph links to https://vite-pwa-org.netlify.app/frameworks/sveltekit.html , see also https://github.com/vite-pwa/sveltekit

they changed this.warn to this.error, which fails the build. https://github.com/rollup/plugins/pull/1361/files#diff-412d92e18a781647b77d5c02b40f7dd4c377fdc88c77e35013af3957135cc879R27 https://rollupjs.org/guide/en/#thiserror this is probably desired, nontheless updating can fail a build that previously passed with a warning.

general note on `await expect`: i think in this instance it's ok to use it, but in general this is not what we want. esp within framework tests we want...

i'll close this, the test run above showed it passing with chromium, so it's not the runner interfering but playwright+webkit