Dominik G.

Results 155 comments of Dominik G.

triggered a rerun on the mac fail

> The HTTP HEAD method requests the [headers](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers) that would be returned if the HEAD request's URL was instead requested with the HTTP [GET](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/GET) method. source: https://developer.mozilla.org/en-US/docs/web/http/methods/head This makes it...

all is still misleading or ambiguous. If you have `POST` and `all`, which one is handling an incoming post request? Isn't clear from the word `all`, which implies all requests...

Is it really needed to parse this at publish and generate an extra module? Can't we just read it from package.json and export? vite: https://github.com/vitejs/vite/blob/main/packages/vite/src/node/constants.ts#L5

> > Can't we just read it from package.json and export? > > Not in the browser do we need it in the browser though? We are already embedding an...

There is also some complexity to ensure that this generated version doesn't cause problems in the release process. - package.json version and version.js version must never be out of sync...

it looks like `changeset version` also does the commit with the updated version already, https://github.com/changesets/changesets/blob/main/packages/cli/src/commands/version/index.ts#L103 so we might have to add a separate commit for updating version.js. You should be...

Instead of embedding the kit version into all clients code, applications that need it could put it into data from root layout load :thinking: I do agree that embedding it...

> Can we make sure that the path is always `./node_modules/@sveltejs/kit/package.json`? Do all package managers work that way? You can use [vitefu](https://github.com/svitejs/vitefu) by @bluwy which has `findDepPkgJsonPath` to find package.json...

fyi https://github.com/changesets/changesets/issues/1166