kit icon indicating copy to clipboard operation
kit copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

chore: switch macos to chromium

Open dominikg opened this issue 1 year ago • 3 comments

to narrow down if the fail relates to safari or macos

this should be temporary.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [ ] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

dominikg avatar Dec 14 '22 14:12 dominikg

@dominikg is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 14 '22 14:12 vercel[bot]

⚠️ No Changeset found

Latest commit: e46df09ac157c9092f2c8eb6e0481d5857e12072

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 14 '22 14:12 changeset-bot[bot]

I converted this to draft since we should be able to simply test it on this branch without merging it

benmccann avatar Dec 14 '22 14:12 benmccann

There's a few PRs dealing with this, so I opened an issue so that we can have a single place to discuss: https://github.com/sveltejs/kit/issues/8578 (or now we have four places instead of three :laughing:)

benmccann avatar Jan 17 '23 23:01 benmccann

i'll close this, the test run above showed it passing with chromium, so it's not the runner interfering but playwright+webkit

dominikg avatar Jan 17 '23 23:01 dominikg