kit icon indicating copy to clipboard operation
kit copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

chore(create-svelte): address flakiness in playwright test

Open mxschmitt opened this issue 2 years ago • 4 comments

Congrats to the version release! Before no web-first assertion was used for the assertion, which means that it did not retry and just failed when the text was not matching. Now its using toHaveText which is recommended and not flaky.

There were more such places inside the sveltekit codebase, seems not related, since its not customer facing, but might still be worth updating.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

mxschmitt avatar Dec 14 '22 18:12 mxschmitt

@mxschmitt is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 14 '22 18:12 vercel[bot]

🦋 Changeset detected

Latest commit: 9687589d243ecab3b713cb528097dc33bdec08b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 14 '22 18:12 changeset-bot[bot]

There were more such places inside the sveltekit codebase, seems not related, since its not customer facing, but might still be worth updating.

Yes, please! PRs welcome to reduce flakiness

benmccann avatar Dec 16 '22 22:12 benmccann

general note on await expect:

i think in this instance it's ok to use it, but in general this is not what we want. esp within framework tests we want to expect acutal state at a specific point, not eventual state after a specific point. this is both faster and more correct

dominikg avatar Dec 17 '22 12:12 dominikg