Dominik G.

Results 155 comments of Dominik G.

I prefer not being @ mentioned in random issues of repositories i made one completely unrelated contribution to. thank you.

the message is intended for users, but I agree that it would be better if it was made at runtime if a missing dependency was detected. vite handles this for...

it is however not a security issue in this case as it only runs "echo". You can safely disable this postinstall script with your package manager if it still concerns...

damnit, there is a prefix interfering with the message format that gh parses https://github.com/sveltejs/kit/actions/runs/3465238448/jobs/5787732669#step:8:324

this raises visibility. if the prefix wasn't there, the`::warning ...` string i linked would turn into a nice big box with a warning icon, title and message, and might even...

apologies for the screenshot from google image search but wasn't able to find a run that has one quickly ![image](https://user-images.githubusercontent.com/611613/201778723-6f81dc3a-2674-4440-b7bc-e7ccf9fb1140.png) regarding the prefix: it seems to be originating from turbo...

https://github.com/vercel/turbo/issues/1363

marking as draft, using test in packages/kit directly to see the potential output without turbo interfering

https://github.com/sveltejs/kit/actions/runs/3465678222 looks like playwrights `github` reporter is a bit noisy due to us running it for multiple apps multiple times, but the flaky reporting works :partying_face:

and here's a run without the noise https://github.com/sveltejs/kit/actions/runs/3465862956