kit icon indicating copy to clipboard operation
kit copied to clipboard

Sveltekit generated project using typescript has vite.config.js file instead of ts

Open thebspin opened this issue 1 year ago • 3 comments

Describe the bug

When generating a typescript project (skeleton) it gets me a vite.config.js file instead of .ts like it used to do in the past. Playwright for example does has it's .ts file for it's config.

Reproduction

Generate a new typescript skeleton project, with all the options on yes (playwright, vitest, prettier and eslint).

Logs

No response

System Info

System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Pro
    Memory: 2.98 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.1 - ~/Library/Caches/fnm_multishells/7782_1671956111960/bin/node
    npm: 8.15.0 - ~/Library/Caches/fnm_multishells/7782_1671956111960/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Firefox Developer Edition: 106.0
    Safari: 16.0
  npmPackages:
    @sveltejs/adapter-auto: ^1.0.0 => 1.0.0 
    @sveltejs/kit: ^1.0.0 => 1.0.1 
    svelte: ^3.54.0 => 3.55.0 
    vite: ^4.0.0 => 4.0.3

Severity

annoyance

Additional Information

No response

thebspin avatar Dec 25 '22 08:12 thebspin

Is vite.config.ts even supported? I can't find reference to it in their docs.

tcc-sejohnson avatar Dec 28 '22 19:12 tcc-sejohnson

yes it is, https://vitejs.dev/config/

Vite also directly supports TS config files. You can use vite.config.ts with the defineConfig helper as well.

dominikg avatar Dec 28 '22 19:12 dominikg

So weird -- I even went to that page and Ctrl+F-ed for vite.config.ts! Thanks... 🙃

tcc-sejohnson avatar Dec 29 '22 03:12 tcc-sejohnson

Doesn't #8258 implement this? Shouldn't it be closed?

aradalvand avatar Jan 09 '23 23:01 aradalvand

Thank you for noticing, closing

dummdidumm avatar Jan 10 '23 07:01 dummdidumm