Antoine du Hamel

Results 948 comments of Antoine du Hamel

157 MiB sounds like a lot! Looking at https://github.com/nodejs/node/actions/runs/19791503862?pr=60897, currently the source code + vendored deps is about 107MiB gzipped (the source code without sharable deps is about 48 MiB...

~`test/parallel/test-runner-output.mjs` is failing when trying to backport this to `v22.x-staging`. Please open a backport PR if we want this on v22.x~ actually, it was relatively trivial to fix, nevermind

There's a build failure to address

Now that we have `ncu-config set -x`, I believe we're closer to the end goal. > 1. We should phase out non-encrypted tokens I'm not sure we can reasonably do...

/cc @nodejs/backporters @nodejs/releasers

Should we just backport https://github.com/nodejs/node/pull/59983?

Landed in 79df8b209b00fd1d4e5343fa036e5c1eb80f43e1

> RC.4 (Including V8 13.6) - https://ci-release.nodejs.org/job/iojs+release/10929/ 📦 ~It~ RC.3 doesn't seem to include the V8 update, `node -p process.versions.v8` reports `13.0.245.25-node.12`, and that's consistent with the content of `v8-version.h`...

Why not use https://github.com/nodejs/node-core-test?