Antoine du Hamel
Antoine du Hamel
My example (https://github.com/nodejs/node/issues/44023#issuecomment-1201628483) is using the `--test` flag, demonstrating its usefulness.
> Also, @aduh95 can you please add me (and @cjihrig probably since he wrote the thing?) to the @nodejs/test_runner team? That's done! > I (personally) think that `glob` is common...
> What happens if two different configurations are set in two different files? > What happens if it is configured once using `--import` and then overridden inside some of the...
@targos can we add the list of commits in the OP? I find it very convenient to have GitHub putting back links to the release proposal PR to see if/when...
Both are wrong IIRC: `` will hide the backlink to v16.x docs, and `` will show a backlink to v17.x that doesn't exist. I think usually we went with the...
> What should be the frequency of the workflow? It currently is set to every Sunday. I think we should set it to run every day. We only release new...
/cc @nodejs/test_runner
> For what it's worth you can do `require(path)` instead of `JSON.parse(fs.readFileSync(path))` which would work since you can `require` JSON files. Except that it would depends on the module cache,...
> On `arm-12+`, `fsPromises.stat` timestamps are returned as 0 even for small positive values. Excluding this platform from test. Doesn't that mean that 9e40873d4281b91fa10aacdad1b3f3326f6f00cb...5311b7d54260a03def6d65215e7ec442be55c4e1 should be fast-tracked on `main` first?
> > Doesn't that mean that [9e40873...5311b7d](https://github.com/nodejs/node/compare/9e40873d4281b91fa10aacdad1b3f3326f6f00cb...5311b7d54260a03def6d65215e7ec442be55c4e1) should be fast-tracked on `main` first? > > Yes, if similar test environment will be used on newer versions as well. I disagree,...